Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute RemoteIndexPrimaryRelocationIT #12389

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Mute RemoteIndexPrimaryRelocationIT #12389

merged 1 commit into from
Feb 20, 2024

Conversation

andrross
Copy link
Member

When this test fails, it takes 15 minutes to timeout. There are many examples like this. While it generally succeeds after a retry or two, I think it is better to mute this test rather than observe regular failures that extend build times.

Related Issues

Relates #9191

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross
Mute RemoteIndexPrimaryRelocationIT
0a835db 
When this test fails, it takes [15 minutes to timeout][1]. There are
many examples like this. While it generally succeeds after a retry or
two, I think it is better to mute this test rather than observe regular
failures that extend build times.

[1]: https://build.ci.opensearch.org/job/gradle-check/33937/testReport/

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross added skip-changelog backport 2.x Backport to 2.x branch labels Feb 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 0a835db

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 0a835db: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69c08c8) 71.49% compared to head (0a835db) 70.67%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12389      +/-   ##
============================================
- Coverage     71.49%   70.67%   -0.83%     
+ Complexity    59869    59166     -703     
============================================
  Files          4960     4960              
  Lines        281166   281166              
  Branches      40861    40861              
============================================
- Hits         201027   198721    -2306     
- Misses        63468    65840    +2372     
+ Partials      16671    16605      -66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross
Copy link
Member Author

❕ Gradle check result for 0a835db: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

#11979

@andrross andrross merged commit 6e702dc into opensearch-project:main Feb 20, 2024
85 of 109 checks passed
@andrross andrross deleted the mute-RemoteIndexPrimaryRelocationIT branch February 20, 2024 20:56
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2024
@github-actions
Mute RemoteIndexPrimaryRelocationIT (#12389)
5fb6bc7 
When this test fails, it takes [15 minutes to timeout][1]. There are
many examples like this. While it generally succeeds after a retry or
two, I think it is better to mute this test rather than observe regular
failures that extend build times.

[1]: https://build.ci.opensearch.org/job/gradle-check/33937/testReport/

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 6e702dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 20, 2024
Merged
kotwanikunal pushed a commit that referenced this pull request Feb 20, 2024
@opensearch-trigger-bot @github-actions
Mute RemoteIndexPrimaryRelocationIT (#12389) (#12396)
2784725 
When this test fails, it takes [15 minutes to timeout][1]. There are
many examples like this. While it generally succeeds after a retry or
two, I think it is better to mute this test rather than observe regular
failures that extend build times.

[1]: https://build.ci.opensearch.org/job/gradle-check/33937/testReport/


(cherry picked from commit 6e702dc)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@andrross
Mute RemoteIndexPrimaryRelocationIT (opensearch-project#12389)
df9e75a 
When this test fails, it takes [15 minutes to timeout][1]. There are
many examples like this. While it generally succeeds after a retry or
two, I think it is better to mute this test rather than observe regular
failures that extend build times.

[1]: https://build.ci.opensearch.org/job/gradle-check/33937/testReport/

Signed-off-by: Andrew Ross <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@andrross @rayshrey
Mute RemoteIndexPrimaryRelocationIT (opensearch-project#12389)
990a902 
When this test fails, it takes [15 minutes to timeout][1]. There are
many examples like this. While it generally succeeds after a retry or
two, I think it is better to mute this test rather than observe regular
failures that extend build times.

[1]: https://build.ci.opensearch.org/job/gradle-check/33937/testReport/

Signed-off-by: Andrew Ross <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@andrross @shiv0408
Mute RemoteIndexPrimaryRelocationIT (opensearch-project#12389)
ff9c534 
When this test fails, it takes [15 minutes to timeout][1]. There are
many examples like this. While it generally succeeds after a retry or
two, I think it is better to mute this test rather than observe regular
failures that extend build times.

[1]: https://build.ci.opensearch.org/job/gradle-check/33937/testReport/

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@kkmr kkmr kkmr approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrross @kkmr @kotwanikunal